miracl / core

MIRACL Core
Apache License 2.0
199 stars 68 forks source link

Support go modules #58

Closed zerjioang closed 2 years ago

zerjioang commented 2 years ago

As new releases of Go enable by default Go modules, it would be good to migrate current Go library to go mod specification

mcarrickscott commented 2 years ago

Yes, good idea. We will look into it.

mcarrickscott commented 2 years ago

Implemented - see go/readme.md

zerjioang commented 2 years ago

@mcarrickscott doing it that way, just for you to know, modules cannot be resolved dynamically by Go, and hence, manual work is required. that's why go.mod file should exist on repo and it is the best practice to follow. Anyway, due to design of the Go files, I doubt about its consistency since multiple files with different package names are located at same level.