search

miracle2k / django-assets

Django webassets integration.
BSD 2-Clause "Simplified" License
89 stars 79 forks source link

Use ASSETS_DEBUG instead of DEBUG #17

Closed rassie closed 10 years ago

rassie commented 11 years ago

Django sets DEBUG to False while running unit tests. Thus, DEBUG is not a good indicator for staticfiles usage, but ASSETS_DEBUG is a better one.

This problem is described in https://github.com/miracle2k/django-assets/issues/3

hexsprite commented 11 years ago

Would love to ASSETS_DEBUG added and a release cut for django-assets. Is there anything holding you back from merging this change?

miracle2k commented 11 years ago

Just my lack of time to have a look at it, but hope that happens soon.

michaelmior commented 11 years ago

+1 for this :)

skyl commented 11 years ago

+1

naktinis commented 10 years ago

+1

hexsprite commented 10 years ago

@miracle2k right now it's pretty broken for this use case of running unit tests which is quite common. merging this patch now would at least make it better (if not perfect). and if something is not quite right i'm sure someone will submit another PR.

polmuz commented 10 years ago

@rassie could you change this pull request to only include the commits related to using ASSETS_DEBUG? This has many changes so I don't think the project owner can merge it as is.

polmuz commented 10 years ago

I have a workaround I'm using until this problem gets fixed: https://gist.github.com/pablomouzo/8709392

I put that snippet in my test settings and things started working.

rassie commented 10 years ago

Sorry, that was unintended. I should probably close this PR and make a new one from a fresh branch. However, I would hope @miracle2k could just make a patch of his own, so I needn't open a new one.

qris commented 10 years ago

+1 please!

rassie commented 10 years ago

There are several other patches and PRs and since my branch is broken, I'm closing this. Would still be happy to see #3 fixed.