miracle2k / flask-assets

Flask webassets integration.
BSD 2-Clause "Simplified" License
454 stars 100 forks source link

Upgrading to Jinja2 version 2.9 breaks "{{ ASSET_URL }}" #122

Closed bmjjr closed 7 years ago

bmjjr commented 7 years ago

Upgrading from Jinja2 version 2.8.1 to version >= 2.9 seems to break {{ ASSET_URL }} imports for common.css and common.js and now need to be explicit with the paths.

For example, this used to work:

{% assets "css_all" %}
<link type="text/css" href="{{ ASSET_URL }}" rel="stylesheet">
{% endassets %}
{% assets "js_all" %}
<script type="text/javascript" src="{{ ASSET_URL }}"></script> 
{% endassets %}

Now need explicit paths:

{% assets "css_all" %}
<link rel="stylesheet" href="{{ url_for('static', filename='pub/css/common.css') }}">
{% endassets %}
{% assets "js_all" %}
<script type="text/javascript" src="{{ url_for('static', filename='pub/js/common.js') }}"></script>
{% endassets %}
cjmielke commented 7 years ago

Happening on our end too. Rolling back to 2.8 gave us a quick fix for now pip install jinja2==2.8

miracle2k commented 7 years ago

This is related to https://github.com/miracle2k/webassets/issues/477. You need to upgrade webassets to fix it.