search

miracle2k / onkyo-eiscp

Control Onkyo A/V receivers over the network; usuable as a script, or as a Python library.
MIT License
466 stars 110 forks source link

Double quotes in options #117

Closed instalator closed 3 years ago

instalator commented 4 years ago

e.g. https://github.com/miracle2k/onkyo-eiscp/blob/b27e8158c09b04a2160e395d9710f6748f431bf5/eiscp-commands.yaml#L493 Is this a mistake or should it be so?

PS https://github.com/miracle2k/onkyo-eiscp/blob/b27e8158c09b04a2160e395d9710f6748f431bf5/eiscp-commands.yaml#L795

peskdale commented 3 years ago

I believe these are incorrect. I'm having similar problems with the CTL command. QSTN works fine, but UP/DOWN include the unicode quotes, so simply don't work when calling them using the onkyo script.

The import script was fixed back in 2017 to correct this but nothing seems to have been done to fix the existing bad commands.

Calling the same commands manually using the raw method works.

peskdale commented 3 years ago

Actually, looking at it some more, that 'fix' in 2017 would not have actually worked. It's looking for a closing quote (201d) for both sides of the command, and so not catching anything with an opening quote (201c).