Sending command to select 'TV' source results in selecting 'CD' source

miracle2k / onkyo-eiscp

Control Onkyo A/V receivers over the network; usuable as a script, or as a Python library.

MIT License

467 stars 110 forks source link

Sending command to select 'TV' source results in selecting 'CD' source #60

Closed joe248 closed 7 years ago

joe248 commented 7 years ago

I have an Onkyo TX-NR646. Using this library within Home Assistant. When I select the TV source using the library, my receiver instead selects the CD source. Looking at commands.py, it's sending a value of 23 for the TV source when it should be sending 12 (see here). I believe this is happening due to the multiple names for value 23 here. I'm not sure what the fix is, though. Perhaps name: [cd, tv, cd] should be changed to name: [cd, tv/cd]?

jeromeloman commented 7 years ago

you are right looks like the command should have been parse as: ('cd', 'tv'/cd') the doc says "sets CD TV/CD"

It's hard to automate the command parser because some description are "CBL/SAT" which you want to split into "CBL", "SAT".. older onkyo don't support TV and CD only "TV/CD" whereas 646 suppors TV and CD seperatly.

Woetsel commented 7 years ago

I have a TX-NR646 as well and I'm running into the same issue.