Closed moskovskiy82 closed 7 years ago
danieljkemp
commented
7 years ago I'm a little confused by all this.
The latest version of HA is tagged to a recent commit. There is a PR in the works to fix a source selection issue, at which point I'll aim the HA requirement line at the new commit, tagged commit (preferable to tagging a commit) or pypi release (best case).
moskovskiy82
commented
7 years ago Ok guess i was a little over my head. Late on i saw that push request contained link to the latest branch. Sorry - not a tech guy. But the files i've found in my ha dir didn't include the fixes for the import statements. So i had to add them manually. If possible if we continue on the HA board? https://community.home-assistant.io/t/onkyo-broken-in-0-42/15273/2 As currently for me the whole setup is broken and not sure if it's overall or only my problem
andrey-git
commented
7 years ago @miracle2k could you release a new pypi version? There were plenty of changes since Aug 2016. It would also allow py3 code to depend on a cut pypi version instead of a brunch. home-assistant/home-assistant#7069
miracle2k
commented
7 years ago A new version was pushed to PyPI.
With all the latest pull requests merged - onkyo-eiscp is working great. The only problem there was a pull request in Home Assistant (quite popular home automation software) to use this library instead of the forked one.
So instead of a new code - we are getting the release 1.0 which contains some bugs especially with python3 compatability. Below are the relevant lines from home-assistant.
miracle2k, is there a possiility you will put up a 1.1 Release so all the fixed bugs will be gone?
-REQUIREMENTS = ['https://github.com/danieljkemp/onkyo-eiscp/archive/'