search

miracle2k / onkyo-eiscp

Control Onkyo A/V receivers over the network; usuable as a script, or as a Python library.
MIT License
466 stars 110 forks source link

Generation of YAML-file not correct #7

Closed cljk closed 11 years ago

cljk commented 11 years ago

I´m not really in Phyton developing - but I used your project YAML-file in a similar project (https://github.com/cljk/jEISCP) as basis to decide of a device is capable of a specific command.

And I think there are difficulties. I don´t know if you plan to fix them - but as example: The official documentation says all devices are capable of Main volume query (MVLQSTN). The YAML-definition of MVLQSTN references to "set12" - but the definition of modelset "set12" misses a complete bunch of devices - especially the one I´m testing on ... *g

Can you give me any hint if there could be a problem in the YAML generator or if I understood the YAML-structure not correct.

miracle2k commented 11 years ago

This is the Excel file that is the basis for the YAML:

http://michael.elsdoerfer.name/onkyo/ISCP-V1.21_2011.xls

If the Excel file does contain different information than my YAML, then my parser is bugged. If it contains the same information with regards to your model, then Onkyo's Excel documentation is incorrect (which wouldn't surprise me in the least), and we could think about how to best fix the YAML file.

cljk commented 11 years ago

Yes, thats exactly the case. According to the Excelfile all devices are capable of MVLQSTN - but in the YAML-file there are missing at least the half of them.

Nevertheless.... I started implementing my own ISCP-Excel-Parser-Sourcecode-generator based on Java. So I´m no further dependent on this and would be okay with closing this issue as unresolved.

miracle2k commented 11 years ago

Turns out there were actually a number of issues with how models where parsed. Thanks for pointing this out.