miracle2k / onkyo-eiscp

Control Onkyo A/V receivers over the network; usuable as a script, or as a Python library.
MIT License
467 stars 110 forks source link

After updates get a lot is not a valid command in zone "main" #74

Open moskovskiy82 opened 6 years ago

moskovskiy82 commented 6 years ago

After some recent update (can't tell exactly then) the following command stopped working (was working fine before)

onkyo -n709 internet-radio-preset=2 Error: "internet-radio-preset" is not a valid command in zone "main"

miracle2k commented 6 years ago

Are you sure? Which version is that? Make sure it's the lastest one. I just tried it and the command seems to work.

miracle2k commented 6 years ago

Actually, strike that. I can reproduce it.

miracle2k commented 6 years ago

This was broken in 94d7c42a0ff1bf286ee16c4cc2bb102b0ec3ed5e.

Reason is that in the Onkyo Excel file, this and a handful of other commands where moved to a new tab (NET_USB)

moskovskiy82 commented 6 years ago

So any chances that the fix will make iit into a new release in the near future? Home-assistant will be soon updated to 0.52 and there is already included PR to bring version 1.23 of your great onkyo-eiscp

And as a workaround... Looked at the commands.py. Can it be just moved by hand?

At the end of commands.py i see the main zone definition 'main': {'HBL': {'auto': '00', 'analog': '01', 'query': 'QSTN'}, And just move all the NPZ to main?

miracle2k commented 6 years ago

I don't know when I find the time to actually fix the import. One option is to add the command manually to the eiscp-commands.yaml file (not commands.py).

Another one is to issue the NPR command (I think that's the one) manually:

Something like this maybe

onkyo -n709 NPR2

moskovskiy82 commented 6 years ago

Where can i find that file?

Installed 1.24 along side outside virtual enviroment via easy_install.

Running

/usr/local/bin/onkyo -n709 internet-radio-preset=4
still gives
('Error:', ValueError('"internet-radio-preset" is not a valid command in zone "main"',))

Running

$ /usr/local/bin/onkyo -n709 NPR4
Traceback (most recent call last):
  File "/usr/local/bin/onkyo", line 11, in <module>
    load_entry_point('onkyo-eiscp==1.2.4', 'console_scripts', 'onkyo')()
  File "build/bdist.linux-armv7l/egg/eiscp/script.py", line 179, in run
  File "build/bdist.linux-armv7l/egg/eiscp/script.py", line 136, in main
  File "build/bdist.linux-armv7l/egg/eiscp/core.py", line 463, in raw
  File "build/bdist.linux-armv7l/egg/eiscp/core.py", line 270, in filter_for_message
ValueError: Timeout waiting for response.

And $ sudo find /* -name "*eiscp-commands.yaml*"

Produces no result

moskovskiy82 commented 6 years ago

Sorry to bug - but maybe some other workaround possible?

unixgeex commented 6 years ago

Same here NPR command not working.

$ onkyo --host 192.168.x.x --port 60128 NPR05

Traceback (most recent call last):
  File "/usr/local/bin/onkyo", line 9, in <module>
    load_entry_point('onkyo-eiscp==1.2.4', 'console_scripts', 'onkyo')()
  File "/usr/local/lib/python2.7/dist-packages/onkyo_eiscp-1.2.4-py2.7.egg/eiscp/script.py", line 179, in run
  File "/usr/local/lib/python2.7/dist-packages/onkyo_eiscp-1.2.4-py2.7.egg/eiscp/script.py", line 136, in main
  File "/usr/local/lib/python2.7/dist-packages/onkyo_eiscp-1.2.4-py2.7.egg/eiscp/core.py", line 463, in raw
  File "/usr/local/lib/python2.7/dist-packages/onkyo_eiscp-1.2.4-py2.7.egg/eiscp/core.py", line 270, in filter_for_message
ValueError: Timeout waiting for response.

Please help.

unixgeex commented 6 years ago

Figured out something until NPR/NPZ are fixed ... Just do whatever action sequence to get the internet radio to play. For preset4 (down key three times on the root menu) :
onkyo --host 192.168.x.x --port 60128 SLI28 NTCRETURN NTCRETURN NTCRETURN NTCDOWN NTCDOWN NTCDOWN NTCSELECT NTCSELECT Not neat ... but works for me.

NextNebula commented 6 years ago

I can't seem to get setting an internet radio preset working either.

ErikMinekus commented 6 years ago

I simply moved everything from the "dock" zone to the "main" zone and regenerated commands.py, which fixes the issue for now. Download here and put it in the eiscp folder.

tpetri commented 5 years ago

Hi, any chance this could be looked at at some point?

Fidelity88 commented 5 years ago

+1!

unixgeex commented 5 years ago

Sorry to bug, is going to be look at ?