miracle2k / webassets

Asset management for Python web development.
BSD 2-Clause "Simplified" License
921 stars 258 forks source link

Removed depacated sass options #516

Closed tibicen closed 4 years ago

tibicen commented 5 years ago

I've removed options like:

which produces error for basic sass commandline. Probably they are not more commandline arguments.

Not advanced sass user, so please verify the issue.

tibicen commented 5 years ago

Yep, I'm assuming it failed cause my additions. And checks probably will fail, cause of those.

miracle2k commented 5 years ago

Which version of sass do you have installed?

$ sass --version
Ruby Sass 3.7.2
michael at dolores in ~
$ sass --help | grep line-comments
        --line-comments
mwchase commented 5 years ago

For my part, the output is

$ sass --version
1.15.3

and $ sass --help | grep line-comments (no output) I was using the ruby gem, but then that got uninstalled, and when I went to the Sass site, it told me to install some other version, and I installed the Dart version with Homebrew, because that was easy.

tibicen commented 5 years ago

True i've installed sass from chocolatey, but was checking those also at fedora and realized it has all the options. But going back to win10 chocolatey version (dart) it lacks it... maybe we can place it as optional values, this would solve those "versions version" errors.

$ sass --version
1.16.0
$ sass
Sass to CSS.

Usage: sass <input.scss> [output.css]
       sass <input.scss>:<output.css> <input/>:<output/>

=== Input and Output ===================
    --[no-]stdin               Read the stylesheet from stdin.
    --[no-]indented            Use the indented syntax for input from stdin.
-I, --load-path=<PATH>         A path to use when resolving imports.
                               May be passed multiple times.

-s, --style=<NAME>             Output style.
                               [expanded (default), compressed]

    --update                   Only compile out-of-date stylesheets.

=== Source Maps ========================
    --[no-]source-map          Whether to generate source maps.
                               (defaults to on)

    --source-map-urls          How to link from source maps to source files.
                               [relative (default), absolute]

    --[no-]embed-sources       Embed source file contents in source maps.
    --[no-]embed-source-map    Embed source map contents in CSS.

=== Other ==============================
    --watch                    Watch stylesheets and recompile when they change.
    --[no-]poll                Manually check for changes rather than using a native watcher.
                               Only valid with --watch.

    --[no-]stop-on-error       Don't compile more files once an error is encountered.
-i, --interactive              Run an interactive SassScript shell.
-c, --[no-]color               Whether to emit terminal colors.
-q, --[no-]quiet               Don't print warnings.
    --[no-]trace               Print full Dart stack traces for exceptions.
-h, --help                     Print this usage information.
    --version                  Print the version of Dart Sass.
miracle2k commented 5 years ago

Ok, so there is a new version written in Dart, and the Ruby version is being phased out. I think the proper way forward is to:

  1. Rename the current filter to RubySass.
  2. Implement a separate filter based on the Dart version, taking over the "sass" name.
  3. Release a new major version, semver-style.

Would merge a PR to this effect.