Modernize webassets - Githubissues

miracle2k / webassets

Asset management for Python web development.

BSD 2-Clause "Simplified" License

924 stars 260 forks source link

Modernize webassets #553

Open offbyone opened 2 months ago

offbyone commented 2 months ago

CI setup for supported Pythons
Add pytest xdist for looponfail
Fix test gaps
Fix the deprecation warning for invalid escapes
Fix the deprecation warning for find_executable
Mark webassets as typed
Bulk update the tests to drop the nosetest format
tox updated to use tox-uv

Related Issues

Fixes #551

offbyone commented 2 months ago

Here's a CI run with the current tox config: https://github.com/offbyone/webassets/actions/runs/11026671771

I believe that readthedocs will still build this as-is, but I'm not 100% sure; it'd be nice to set up PR-based builds for RTD if you haven't and we can see if those work.

justinmayer commented 4 weeks ago

Hey Chris. What do you think about my proposal in https://github.com/miracle2k/webassets/issues/555?

offbyone commented 4 weeks ago

Maybe I'm misunderstanding the relationship between the two, but I believe that this library is a dependency of the Pelican plugin; in order to get that plugin to work, this update needed to happen.

I'd be up for a "courteous fork" under a new name, or potentially to vendor this code into the Pelican plugin, but I'm not sure that it can be directly folded in. I think this code is where the meat of the pelican-plugin-webassets logic lives.

That's why I'm using my own forks of them here

justinmayer commented 4 weeks ago

If that is the case, my vote would be for vendoring the needed code into the aforementioned Pelican plugin repository.

offbyone commented 4 weeks ago

I'm fine with that.

justinmayer commented 4 weeks ago

If you (or anyone else for that matter) would like to submit PRs to that effect, I’d be happy to merge them post-haste, as well as make sure you have the requisite commit bit for that repo if you don’t already 😊