search

miraclebg / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

PHP version requirements are stated incorrectly #272

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Minify commit/version: 2.1.5
PHP version: 5.2.17

The requirements listed on http://code.google.com/p/minify/ specify the 
following:

Requirements
PHP 5.1.6.
The commonly installed zlib extension is recommended for HTTP encoding 
functionality.
Version 1.0.1 required PHP 5.2.1+.

However, the lib requires 5.3 (at least with 2.1.5). The only 5.3 only thing I 
can see is the "namespace" declaration.

Original issue reported on code.google.com by ed...@eddiemonge.com on 13 Aug 2012 at 7:58

GoogleCodeExporter commented 9 years ago 
Ok just kidding about the declaration being the only thing. There are namespace 
stuffs used elsewhere as well. 

The expected outcome of this issue will be to update the requirements page with 
the corrected requirements.

Original comment by ed...@eddiemonge.com on 13 Aug 2012 at 8:03

GoogleCodeExporter commented 9 years ago 
Now says, "PHP 5.1.6 / command-line tools require 5.3". Default 
installation/usage should not need 5.3.

Original comment by mrclay....@gmail.com on 13 Aug 2012 at 8:21

GoogleCodeExporter commented 9 years ago 
Would it be possible to have the CLI be a separate folder or something? My 
version control runs PHPLint and since its 5.2.17, it will not allow the 5.3 
code to be accepted.

Original comment by ed...@eddiemonge.com on 13 Aug 2012 at 8:27

GoogleCodeExporter commented 9 years ago 
Eventually, though not real soon, the whole library will be 5.3. If you don't 
need CLI, fork on github and remove it from your branch. That way you can still 
merge in new commits from upstream.

Original comment by mrclay....@gmail.com on 13 Aug 2012 at 8:53