search

miraclx / freyr-js

A tool for downloading songs from music streaming services like Spotify and Apple Music.
https://git.io/freyr-js
Apache License 2.0
1.39k stars 90 forks source link

File exist should ignore file extension #580

Closed Zenthae closed 8 months ago

Zenthae commented 9 months ago

Hello,

I believe that the check for already existing music should not include the file extension. It would allow people, like me 😄, to fuse an existing library with other format, like flac.

I think it's this part of the code that need to be changed

https://github.com/miraclx/freyr-js/blob/3861d0711d07b5772bb909a53b23b97227dd0553/cli.js#L1375-L1390

miraclx commented 8 months ago

Not sure I get the point here, can you elaborate?

Zenthae commented 8 months ago

You see, I have an existing music library with a mix of FLAC and mp3 files. Since you include the file extension when checking for existing files, it does not detect other format. Which makes duplicates.

miraclx commented 8 months ago

Ah I see, but I'm afraid I don't think this is something freyr can change. Even if freyr was removing the extension, the format of the track name itself may not be consistent with what freyr uses. It's difficult to determine where to draw the line.

The check for whether the track exists or not isn't meant to be compatible with your existing library, it's just there to make sure freyr never redownloads a track it already downloaded before.

I think the folder for tracks managed by freyr should be independent from other tracks.