miraclx / freyr-js

A tool for downloading songs from music streaming services like Spotify and Apple Music.
https://git.io/freyr-js
Apache License 2.0
1.37k stars 89 forks source link

Downloaded files are all 2.15 GB in size #662

Closed joniler closed 3 months ago

joniler commented 4 months ago

Thanks for the awesome tool!

For some reason though, All tracks I download are 2.15 GB no matter what. Is there a config option to adjust this so that they convert down to their actual size? See screenshot:

image

Any guidance here would be appreciated... might be a bug?

Jacxk commented 4 months ago

Hi there, I also had this issue and it seems to be an issue with AtomicParsley, to fix this you could either use the docker version of freyr or use the version of AtomicParsley @miraclx provided here https://github.com/miraclx/freyr-js/issues/628#issuecomment-1890438709. You can either add the path to the downloaded binary on the config file (you can also set the env variable ATOMIC_PARSLEY_PATH to the path of the downloaded file or use freyr --atomic-parsley [path]) or move the file to /usr/local/bin. Make sure you allow AtomicParsley to run on from Security & Privacy tab.

Hope that helps you!

aarnaegg commented 2 months ago

Hi there, I also had this issue and it seems to be an issue with AtomicParsley, to fix this you could either use the docker version of freyr or use the version of AtomicParsley @miraclx provided here #628 (comment). You can either add the path to the downloaded binary on the config file (you can also set the env variable ATOMIC_PARSLEY_PATH to the path of the downloaded file or use freyr --atomic-parsley [path]) or move the file to /usr/local/bin. Make sure you allow AtomicParsley to run on from Security & Privacy tab.

Hope that helps you!

Im having problems figuring out where to drop atomic parsley 20230114.175602.21bde60. I don't have /usr/local/bin. If I create a bin folder in usr/local Freyr said atomic parsley is not installed.

Jacxk commented 2 months ago

@aarnaegg I believe you can go to the config file (or the environmental variable) and specify the path to it or use the command to set the path. Also, make sure the file name is AtomicParsley.

miraclx commented 2 months ago

@aarnaegg, there's a couple of approaches here:

  1. if you know where freyr is installed, you can place it inside the bins/posix dir at the root (you'll most likely need to create it)

    If you installed freyr via npm/yarn or whatever else, they'll likely symlink it so you can do this to drop you into the installed location for freyr

    $ cd $(dirname $(realpath $(which freyr)))
  2. But I think the ideal approach is to have AtomicParsley globally accessible, and personally I recommend having a ~/.local/bin dir which is part of your PATH and installing AtomicParsley there. Freyr will find it.

    You note:

    If I create a bin folder in usr/local Freyr said atomic parsley is not installed.

    You still have to ensure it's part of your PATH. You can check your definitions here to ensure it's part of it:

    $ echo $PATH | tr ':' '\n'
  3. Finally, freyr supports specifying an "override" path via the --atomic-parsley flag or the ATOMIC_PATSLEY_PATH env.

    $ freyr --atomic-parsley ./path/to/AtomicParsley ...
    $ ATOMIC_PARSLEY_PATH=./path/to/AtomicParsley freyr ...

Thanks @Jacxk, for your support. PS: freyr scans for AtomicParsley and atomicparsley, but macOS's APFS is case-insensitive anyway, so anything works.

aarnaegg commented 2 months ago

I found it was because I had to install Rosetta because I'm using a M1 MacBook. I got it working now. Thanks!