search

miraclx / freyr-js

A tool for downloading songs from music streaming services like Spotify and Apple Music.
https://git.io/freyr-js
Apache License 2.0
1.37k stars 89 forks source link

chore: assert the presence of the yt-dlp dep #670

Closed miraclx closed 2 months ago

miraclx commented 2 months ago

Add a test to ensure the yt-dlp binary is present after install has been run.

Found out why CI was failing, over-dependence on caches. Looks like 2 months ago, we cached an image that didn't appropriately download the yt-dlp subdependency of youtube-dl-exec and we kept reusing that image since freyr didn't change in this period of time.

Had to evict caches, and now it works! - miraclx/freyr-js/actions/runs/8623905754/job/23690297872

Originally posted by @miraclx in https://github.com/miraclx/freyr-js/issues/669#issuecomment-2048877760

Linked: https://github.com/microlinkhq/youtube-dl-exec/issues/190

github-actions[bot] commented 2 months ago
--- 🐋 🤖 **A docker image for this PR has been built!** ```console docker pull freyrcli/freyrjs-git:pr-670 ``` | [**Base (master)**][base-url] | [![](https://img.shields.io/docker/image-size/freyrcli/freyrjs-git/606bbd4?color=gray&label=%20&logo=docker)][base-url] | | :-: | - | | [**This Patch**][pr-url] | [![](https://img.shields.io/docker/image-size/freyrcli/freyrjs-git/pr-670?color=gray&label=%20&logo=docker)][pr-url] | [![][compare-img]][compare-url] ---
What's this? This docker image is a self-contained sandbox that includes all the patches made in this PR. Allowing others to easily use your patches without waiting for it to get merged and released officially. For more context, see https://github.com/miraclx/freyr-js#docker-development.