search

mirage-sql / mirage

Mirage-SQL - the SQL Centric Database Access Library for Java
Apache License 2.0
59 stars 21 forks source link

JUnit dependency #43

Closed ahamana closed 7 years ago

ahamana commented 7 years ago

The JUnit dependency is "compile" configuration. So, build artifacts(e.g. war, jar etc) include "junit.jar" in them. Is this correct setting?

aadrian commented 7 years ago

Is this correct setting?

Yes, I think this is correct since the https://github.com/mirage-sql/mirage/tree/master/src/main/java/com/miragesql/miragesql/test package needs it.

We plan to split this project into modules: https://github.com/mirage-sql/mirage/issues/30 with the next version, so that the core won't include this functionality (or the tooling) only if explicitly imported.

ahamana commented 7 years ago

Oh, I see. Many thanks for your explanation.