search

mirage-sql / mirage

Mirage-SQL - the SQL Centric Database Access Library for Java
Apache License 2.0
59 stars 24 forks source link

Fix unstable testcase #66

Closed takezoe closed 6 years ago

aadrian commented 6 years ago

@takezoe thank you for the fix, but I don't think it's really fixing it. See #63

The problem seem to be the the order of fields/methods in the beans is not predictable when reading it, in order to generate a reproducible order for the insert and update columns in the statements.

So far I found this: https://stackoverflow.com/questions/5001172/java-reflection-getting-fields-and-methods-in-declaration-order as a solution, but it's not that easy, since https://github.com/wmacevoy/kiss/blob/master/src/main/java/kiss/util/Reflect.java#L123 needs to be tested really well.

takezoe commented 6 years ago

Then we should disable these testcases until fix this problem. These unstable testcases confuse contributors by unreasonable failure for pull requests from them.

aadrian commented 6 years ago

Then we should disable these testcases until fix this problem. These unstable testcases confuse contributors by unreasonable failure for pull requests from them.

@takezoe You are right. Even worse is that they happen randomly :( .