Polish code style - Githubissues

mirage-sql / mirage

Mirage-SQL - the SQL Centric Database Access Library for Java

Apache License 2.0

59 stars 24 forks source link

Polish code style #69

Closed wreulicke closed 5 years ago

wreulicke commented 5 years ago

This PR fixes followings. there are no feature improvements.

rewrite to foreach statement
remove unused imports
use StandardCharsets
use append(text, pos1, pos2) instead of append(substirng(text, pos1, pos2))
remove duplicate condition branch
reduce unnecessary auto boxing (CallableStatement.getXXX return primitive such as CallableStatement.getBoolean) and remove unnecessary null check.
add final modifier to synchronization object

If this PR is crowded, I will separate.