search

mirage / awa-ssh

Purely functional SSH library in ocaml.
ISC License
104 stars 12 forks source link

Fix isomorphism between of_seed/of_string and awa_gen_key #40

Closed dinosaure closed 2 years ago

dinosaure commented 2 years ago

Redo this PR with X509.Private_key.of_string (which requires x509.0.15.2. This small patch brings an other type error in some way related to #36. However, we can merge it as is. I did not really test the isomorphism nor look deeper on X509.Private_key.of_string.

hannesm commented 2 years ago

Thanks for your PR. I just pushed a commit to your branch, what do you think about the result? :) it attempts to modify less code, and have the same observational behaviour (not removing the log messages).

dinosaure commented 2 years ago

Good for me :+1:.