mirage / awa-ssh

Purely functional SSH library in ocaml.
ISC License
104 stars 12 forks source link

Handle unknown keys more gracefully #57

Closed reynir closed 1 year ago

reynir commented 1 year ago

When a client connects with an unknown key type (e.g. ECDSA) to an awa-ssh server the server doesn't recognize the key type and gives up parsing. It would be more graceful if the server handles unknown keys by informing the client that the provided key isn't accepted.

hannesm commented 1 year ago

at the same time, would it be worth to add more KEX to the server implementation? I can do that for you, or together with you, if you like :)

hannesm commented 1 year ago

The ECDH key exchange algorithms are supported in #63 for the server. Still, only ED25519 and RSA hostkeys (client keys) - so I will leave this open.

hannesm commented 1 year ago

done with #68