search

mirage / awa-ssh

Purely functional SSH library in ocaml.
ISC License
104 stars 12 forks source link

awa-lwt rekey issue #60

Closed reynir closed 1 year ago

reynir commented 1 year ago

Same issue as in #58.

hannesm commented 1 year ago

this is not an issue, since in awa-lwt, Lwt.pick is used (and the timeout is cancelled when some other promise is fulfilled).

palainp commented 1 year ago

This is just a minor comment to explain why Lwt.nchoose_split is used (and not Lwt.pick) in awa-mirage: I had some issues when the timeout is triggered and there is still something to handle on the network side (which is overridden by the timeout) (e.g. https://github.com/mirage/awa-ssh/pull/35#issuecomment-956005503).