mirage / awa-ssh

Purely functional SSH library in ocaml.
ISC License
104 stars 12 forks source link

More kex #67

Closed hannesm closed 1 year ago

hannesm commented 1 year ago

this is #63 again, but needs some investigation why there are signature failures

hannesm commented 1 year ago

this is now rebased on top of the main branch. This has also been debugged and tested, see https://github.com/mirage/awa-ssh/pull/67/commits/f82537aef9cc1cbd7eac564da65e7f7e53e1f5d0 for the culprit of "bad signature"...

//cc @reynir in case you would like to test this. I did it in a loop, and couldn't find any bad signatures anymore.

hannesm commented 1 year ago

CI failures such as

[ERROR] Package alcotest has no version dev.

[ERROR] Package alcotest-async has no version dev.

[ERROR] Package alcotest-js has no version dev.

[ERROR] Package alcotest-lwt has no version dev.

[ERROR] Package alcotest-mirage has no version dev.

I've observed in the mirage/mirage repository as well (see https://github.com/mirage/mirage/pull/1417#issuecomment-1597119204), and wonder whether "OCaml CI" is just in an unhappy state.

hannesm commented 1 year ago

I reported the CI issue at https://github.com/ocurrent/ocaml-ci/issues/829