search

mirage / bechamel

Agnostic benchmark in OCaml (proof-of-concept)
MIT License
44 stars 15 forks source link

Add hardware perf measures #30

Closed OlivierNicole closed 2 years ago

OlivierNicole commented 2 years ago

Simply add the missing glue. I also made the unit labels fit within 5 characters.

dinosaure commented 2 years ago

Thanks! I think it will be ready to merge.

OlivierNicole commented 2 years ago

Actually, maybe just wait a bit: I realized that this code gives me a “No such file or directory” error when using the library, because of the ref_cpu_cycles apparently not existing on all kernels (processors?).

Edit.: and this, even when not trying to use the ref_cpu_cycles measure.

OlivierNicole commented 2 years ago

I have removed the measures that are not present on my machine and prevent the library from loading. I believe it should be more usable now.

dinosaure commented 2 years ago

The PR is fine, the error on the documentation is due to a downgrade of ocplib-json-typed which is not really expected. Ready for a release so. Thanks!