charrua-core is now charrua

mirage / charrua

A DHCP library in OCaml

http://mirage.github.io/charrua/

ISC License

55 stars 18 forks source link

charrua-core is now charrua #100

Closed hannesm closed 5 years ago

hannesm commented 5 years ago

charrua-server is the server now (separate directory and opam package)

I ended up copying some functionality of lib/util.ml to lib/dhcp_wire.ml and move lib/util.ml to server.

see #69

hannesm commented 5 years ago

mirage-skeleton changes for this https://github.com/mirage/mirage-skeleton/pull/270

hannesm commented 5 years ago

imho ready, CI is green. will proceed with a squash-merge (and github rename charrua-core to charrua) this weekend unless someone is against this

yomimono commented 5 years ago

No objections from here.

avsm commented 5 years ago

lgtm. I think this will need an additional change for the cstruct>4 compat change, since it needs to use Cstruct_sexp

hannesm commented 5 years ago

@avsm hmm, did you try to compile with cstruct 4.0.0? as far as I'm aware, this has already been fixed by @TheLortex in #99 (it looks CI agrees with that as well by installing cstruct 4.0.0) :D

avsm commented 5 years ago

Thats good by me! I just noticed that its the last constraint holding us back