support ipaddr/macaddr.4.0.0 interfaces

mirage / charrua

A DHCP library in OCaml

http://mirage.github.io/charrua/

ISC License

55 stars 18 forks source link

support ipaddr/macaddr.4.0.0 interfaces #103

Closed avsm closed 5 years ago

avsm commented 5 years ago

also:

cleanup warnings in dune's default dev profile (@avsm)
test with OCaml 4.08.0 (@avsm)

hannesm commented 5 years ago

I briefly looked through this PR, and think:

it would benefit if different changesets (fix compiler warnings; port to new API) would be different commits
I dislike disabling of warnings, and prefer to either fix them or leave them alone

avsm commented 5 years ago

Good points both; I've pushed fixes as separate commits. Also spotted a minor bug in 1b94f9a82b2839311e55e164154573408e074f0c while fixing the unused bindings warnings that could use some confirmation.

hannesm commented 5 years ago

thanks, that looks good to me!

avsm commented 5 years ago

Will wait till https://github.com/mirage/arp/pull/16

avsm commented 5 years ago

Restarted CI now that arp/ethernet are released