search

mirage / charrua

A DHCP library in OCaml
http://mirage.github.io/charrua/
ISC License
55 stars 18 forks source link

Fix dune warning #108

Closed samoht closed 4 years ago

samoht commented 4 years ago

Otherwise building the project gives:

$ dune build
File "dune-project", line 3, characters 14-17:
3 | (using menhir 2.0)
                  ^^^
Warning: Version 2.0 of the menhir extension is not supported until version
1.4 of the dune language.
Supported versions of this extension in version 1.2 of the dune language:
- 1.0
hannesm commented 4 years ago

LGTM

samoht commented 4 years ago

@hannesm is that ok if I make a point release of charrua with just that fix?

hannesm commented 4 years ago

@samoht sure, I'd propose to update all the opam files in this repository to depend on "dune" {>= "1.4.0"}.

samoht commented 4 years ago

Ok I've add constraints to the dune files and a changelog entry.

hannesm commented 4 years ago

LGTM