Fix dhcp client id - Githubissues

mirage / charrua

A DHCP library in OCaml

http://mirage.github.io/charrua/

ISC License

55 stars 18 forks source link

Fix dhcp client id #97

Closed lynxis closed 5 years ago

lynxis commented 5 years ago

Clients which uses a Client Id with type 0xff could not get an dhcp lease. The Problem is in the Client Id type of 0xff. Charrua ignored the type and set it internal to 0x00. When the client sent the "Request", charrua could not find the matching Offer because of the mismatch in the client id.

client | server -> DISCOVER <- OFFER -> REQUEST <- NAK!

Note to previous self:

I've no idea how I fixed it. Can you explain it?

lynxis commented 5 years ago

Hi @hannesm

maybe you help me understand what I've done here. But it works ;)

Best, lynxis

lynxis commented 5 years ago

Doesn't work yet. works for me, but for other client id == type 0x0 it's broken.

lynxis commented 5 years ago

Superseeded by #98.