30 discovers a dead code about implementation of CRC32 in C:
CHECKSEUM_U4 is defined only if STDC is defined (which is a part of zlib.h only)
because CHECKSEUM_U4 is never defined, BYFOUR is never defined
a huge part of the implementation of CRC32 is dead because that
The only requirement about the definition of CHECKSEUM_U4 is the existence of <limits.h>. Currently, this header exists into ocaml-freestanding, UNIX and Windows (tested locally). I'm not sure that it will fix the cross-compilation (when I can not reproduce such context in my Windows) but it should help to fix the problem I think.
dinosaure
commented
4 years ago
30 discovers a dead code about implementation of CRC32 in C:
CHECKSEUM_U4is defined only ifSTDCis defined (which is a part ofzlib.honly)CHECKSEUM_U4is never defined,BYFOURis never definedThe only requirement about the definition of
CHECKSEUM_U4is the existence of<limits.h>. Currently, this header exists intoocaml-freestanding, UNIX and Windows (tested locally). I'm not sure that it will fix the cross-compilation (when I can not reproduce such context in my Windows) but it should help to fix the problem I think.