On Windows, run PKG_CONFIG_PATH through cygpath

mirage / checkseum

MIT License

15 stars 13 forks source link

On Windows, run PKG_CONFIG_PATH through cygpath #59

Closed MisterDA closed 2 years ago

MisterDA commented 2 years ago

When using OCaml for Windows, PKG_CONFIG_PATH is usually in Windows style. GNU Make with the shell function will call Cygwin's Unix shell which doesn't recognize Windows paths. If we're on a Windows system, and if we find cygpath, convert the path list to Unix style.

dinosaure commented 2 years ago

I would like to accept this PR but it seems that the AppVeyor CI (which tests checkseum on Windows) does not work. I'm not sure how to fix that correctly. May be ocaml/setup-ocaml has a Windows support and we should move on this system instead of our great old AppVeyor CI.

MisterDA commented 2 years ago

I've added GHA support and removed the AppVeyor scripts. The build succeeds on my fork.

dinosaure commented 2 years ago

Thanks!