Closed jonahbeckford closed 2 years ago
The GitHub Actions Windows target: https://github.com/jonahbeckford/checkseum/actions/runs/1965670821
Nice! Do you mind opening another PR to switch the CI from appveyor (😱 ) to GHA?
Nice! Do you mind opening another PR to switch the CI from appveyor (😱 ) to GHA?
Hmm. I have never used appveyor. It seems like appveyor.xml has already been deleted and the GitHub Actions already work. So it seems like a problem with the AppVeyor service itself still triggering on every commit.
I came across https://github.com/appveyor/ci/issues/3585 which has some comments about a) deleting the GitHub webook and/or b) faking data into the GitHub Status API. Or just c) have @dinosaure delete the https://ci.appveyor.com/project/dinosaure/checkseum-jx0qp/history project.
c) have @dinosaure delete the https://ci.appveyor.com/project/dinosaure/checkseum-jx0qp/history project.
It's done, thanks! I will try to do a release next week.
This PR switches from
WIN32
to_WIN32
because, at minimum,WIN32
is not defined with MSVC compilers.According to https://reviews.llvm.org/D40285 the
_WIN32
macro works across MSVC, GCC and clang compilers:So
WIN32
is incorrect, even on GCC compilers.The
_WIN32
macro is documented at https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170