search

mirage / functoria

A DSL to invoke otherworldly functors
ISC License
63 stars 21 forks source link

Invoke "opam list" with --color=never #177

Closed ehmry closed 4 years ago

ehmry commented 5 years ago

This is a fix for a problem with color and undeline escape sequences in the output of opam list.

hannesm commented 5 years ago

this looks good to me and addresses #175 point (4).

hannesm commented 5 years ago

only thing I'm not sure about is whether there is a nicer way -- could the parent process which executes the opam list do this without a real terminal (i.e. as before), so opam list will automatically detect to not emit ansi colour sequences.

samoht commented 4 years ago

only thing I'm not sure about is whether there is a nicer way I think controlling opam with an explicit color argument is the right way to go as we won't have to guess how opam detects pseudo-terminals (and it changed between opam1 and opam2 if I remember correctly)