search

mirage / functoria

A DSL to invoke otherworldly functors
ISC License
63 stars 21 forks source link

Do not compile config.ml with -warn-error by default #193

Closed samoht closed 4 years ago

samoht commented 4 years ago

A tentative fix for https://github.com/mirage/functoria/issues/182

Both functoria and mirage are defining the same flag, so I'm not sure if this will work very well without a patch to mirage too (or we will have to rename that flag).

hannesm commented 4 years ago

thanks @samoht -- another solution would be to never warn_error (and thus revert the behaviour to functoria pre-3). in functoria-4/mirage-4 (developed on mirage#master), we can find a cleaner solution (enable warn-error by default, as dune does, and have a single command-line flag to disable warn-error). this would allow us to not have to struggle with lower bounds and cut unnecessary releases. what do you think?

samoht commented 4 years ago

yes that's a good idea, that'd make that patch even simpler. I'll push this shortly.

samoht commented 4 years ago

Updated, and tested on a small example : the deprecation messages in config.ml are still printed out (annoyingly they are duplicated) but at least mirage configure complete fine.

hannesm commented 4 years ago

cool, thanks! should we merge + release this then?

samoht commented 4 years ago

Yes, I'm making a release.

samoht commented 4 years ago

functoria-3.1.0 has been submitted: https://github.com/ocaml/opam-repository/pull/15968