search

mirage / irmin-server

A high-performance server for Irmin
ISC License
23 stars 7 forks source link

Fix: Error when running server and typo in readme #30

Closed dinakajoy closed 2 years ago

dinakajoy commented 2 years ago

Running this command - dune exec bin/server/server.exe -- --root ./data throws this error 

dune exec bin/server/server.exe -- --root ./data
Fatal error: exception (Invalid_argument
  "option name -c defined twice (doc strings are 'The type of user-defined contents (one of `string', `json' or `json-value'). Default is `string'.' and 'Encoding to use for messages')")
Raised at Stdlib.invalid_arg in file "stdlib.ml", line 30, characters 20-45
Called from Stdlib__List.fold_left in file "list.ml", line 121, characters 24-34
Called from Cmdliner_cline.arg_info_indexes.loop in file "cmdliner_cline.ml", line 53, characters 23-54
Called from Cmdliner_cline.create in file "cmdliner_cline.ml", line 179, characters 27-46
Called from Cmdliner.Term.term_eval in file "cmdliner.ml", line 138, characters 20-56
Called from Cmdliner.Term.eval in file "cmdliner.ml", line 221, characters 18-44
Called from Dune__exe__Server in file "bin/server/server.ml", line 60, characters 15-42

Patrick gave this the fix and suggested a PR to fix the issue.

I also noticed a typo in the README.md file and added the correction as well

zshipko commented 2 years ago

Good catch, thanks!