Open Ngoguey42 opened 3 years ago
This needs a new scheduling label.
As discussed offline with @n-osborne a few months ago, iter
would be more predictable if min
was made simpler.
min
should be the list of objects that iter
will stop at (i.e. no special case).
A new boolean flag should control whether the min
s are included or excluded from the iteration (i.e. whether or not they are passed to edge
and node
)
Aside from needing more docstrings, more tests (#1134) and maybe some benchmarks, the specifications of
Object_graph.iter
need to be improved.Issues:
iter_p
might be problematic: https://github.com/mirage/irmin/pull/1220#discussion_r550484949rev=false
order of iteration is wrong: https://github.com/mirage/irmin/pull/1220#discussion_r550485036Summaty of the 4 APIs of iter