mirage / irmin

Irmin is a distributed database that follows the same design principles as Git
https://irmin.org
ISC License
1.85k stars 157 forks source link

irmin-pack: adding a volume w/o lower is an error #2199

Closed metanivek closed 1 year ago

metanivek commented 1 year ago

Follow up from #2188 to return an error when calling add_volume and there is no lower configured.

codecov-commenter commented 1 year ago

Codecov Report

Merging #2199 (65b07ed) into main (2edf199) will increase coverage by 0.03%. The diff coverage is 58.53%.

:exclamation: Current head 65b07ed differs from pull request most recent head 07b8535. Consider uploading reports for the commit 07b8535 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
+ Coverage   68.13%   68.16%   +0.03%     
==========================================
  Files         135      135              
  Lines       16255    16313      +58     
==========================================
+ Hits        11075    11120      +45     
- Misses       5180     5193      +13     
Impacted Files Coverage Δ
src/irmin-pack/unix/errors.ml 28.88% <ø> (ø)
src/irmin-pack/unix/gc_worker.ml 4.61% <0.00%> (+0.20%) :arrow_up:
src/irmin-pack/unix/inode.ml 10.00% <0.00%> (-2.50%) :arrow_down:
src/irmin-pack/unix/io_errors.ml 58.33% <ø> (ø)
src/irmin-pack/unix/pack_key.ml 65.38% <0.00%> (-5.45%) :arrow_down:
src/irmin-pack/unix/pack_store.ml 78.60% <9.09%> (-4.12%) :arrow_down:
src/irmin-pack/unix/store.ml 64.59% <64.70%> (+1.20%) :arrow_up:
src/irmin-pack/unix/file_manager.ml 84.48% <88.88%> (+0.35%) :arrow_up:
src/irmin-pack/unix/gc.ml 79.62% <100.00%> (+1.95%) :arrow_up:
src/irmin-fs/unix/irmin_fs_unix.ml 67.74% <0.00%> (-0.65%) :arrow_down:
... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more