mirage / irmin

Irmin is a distributed database that follows the same design principles as Git
https://irmin.org
ISC License
1.84k stars 153 forks source link

irmin-pack: fix GC creation of prefix from lower volume data after migration #2209

Closed art-w closed 1 year ago

art-w commented 1 year ago

After a migration, the GC might have to read live data from the lower volume to construct the prefix (with Dispatcher.read_seq_exn which only supported reading from the upper store).

codecov-commenter commented 1 year ago

Codecov Report

Merging #2209 (c2b3b21) into main (ce09bb7) will decrease coverage by 0.02%. The diff coverage is 44.44%.

:exclamation: Current head c2b3b21 differs from pull request most recent head 9526a48. Consider uploading reports for the commit 9526a48 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2209      +/-   ##
==========================================
- Coverage   68.01%   68.00%   -0.02%     
==========================================
  Files         135      135              
  Lines       16472    16479       +7     
==========================================
+ Hits        11203    11206       +3     
- Misses       5269     5273       +4     
Impacted Files Coverage Δ
src/irmin-pack/unix/dispatcher.ml 59.03% <16.66%> (-3.79%) :arrow_down:
src/irmin-pack/unix/lower.ml 62.04% <100.00%> (+0.27%) :arrow_up:
src/irmin-pack/unix/sparse_file.ml 79.16% <100.00%> (+0.17%) :arrow_up:
src/irmin-fs/unix/irmin_fs_unix.ml 68.38% <0.00%> (+0.64%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more