codecov-commenter
commented
1 year ago Codecov Report
Merging #2212 (d24607c) into main (4dcf5d7) will increase coverage by
0.00%. The diff coverage is77.77%.:exclamation: Current head d24607c differs from pull request most recent head a376c1f. Consider uploading reports for the commit a376c1f to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #2212 +/- ##
=======================================
Coverage 68.09% 68.09%
=======================================
Files 135 135
Lines 16458 16467 +9
=======================================
+ Hits 11207 11214 +7
- Misses 5251 5253 +2 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/irmin-pack/unix/pack_key.ml | 64.91% <50.00%> (-1.13%) |
:arrow_down: |
| src/irmin-pack/unix/lower.ml | 62.58% <100.00%> (+0.54%) |
:arrow_up: |
| src/irmin-pack/unix/pack_store.ml | 79.42% <100.00%> (+0.09%) |
:arrow_up: |
| src/irmin-pack/unix/sparse_file.ml | 79.50% <100.00%> (+0.34%) |
:arrow_up: |
... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR adds a test to confirm the reading a commit and its data in a volume only reads data from that volume.
I discovered that commit keys did not have a volume identifier after read, so this PR also fixes that. The previous behavior didn't break anything, but it's nice to be able to inspect a commit after you read it to know which volume (if any) it came from.