search

mirage / irmin

Irmin is a distributed database that follows the same design principles as Git
https://irmin.org
ISC License
1.84k stars 153 forks source link

Add Conf.pp and Conf.equal #2227

Closed samoht closed 1 year ago

samoht commented 1 year ago

The coverage test fails with:

  ASSERT Chunk0 removed
  File "test/irmin-pack/test_gc.ml", line 1224, character 4:
  FAIL Chunk0 removed

     Expected: `false'
     Received: `true'

  Raised at Alcotest_engine__Test.check in file "src/alcotest-engine/test.ml", line 200, characters 4-261
  Called from Test_pack__Test_gc.Split.v3_migrated_store_splits_and_gc in file "test/irmin-pack/test_gc.ml", line 1224, characters 4-120
  Called from Lwt.Sequential_composition.bind.create_result_promise_and_callback_if_deferred.callback in file "src/core/lwt.ml", line 1849, characters 23-26

Which doesn't seem related.

art-w commented 1 year ago

Thanks! Indeed the failure shouldn't block your PR, I'm guessing it's related to the async deletion of chunk files which makes this test flaky ( https://github.com/mirage/irmin/pull/2221 , cc @adatario )