mirage / irmin

Irmin is a distributed database that follows the same design principles as Git
https://irmin.org
ISC License
1.83k stars 154 forks source link

irmin-mirage-git: update for latest versions of `mirage-kv` #2256

Closed metanivek closed 1 year ago

metanivek commented 1 year ago

This PR updates irmin-mirage-git for the latest mirage-kv (5.0.0+ 6.0.0+).

Closes #2083

adatario commented 1 year ago

For reference this is (one of) the discussion that motivates the removal of batch: https://github.com/mirage/mirage-kv/issues/36

metanivek commented 1 year ago

For reference this is (one of) the discussion that motivates the removal of batch: mirage/mirage-kv#36

Yeah, I saw that (and Irmin-mirage-git may be closest to implementing the described semantics (I am not sure, I don't fully understand the behavior from a quick read of the code) :sweat_smile:).

I do think batch should probably be re-evaluated, but didn't want to break the public API in this PR.

codecov-commenter commented 1 year ago

Codecov Report

Merging #2256 (d192ebe) into main (0075198) will decrease coverage by 0.02%. The diff coverage is n/a.

:exclamation: Current head d192ebe differs from pull request most recent head 8b0e4fd. Consider uploading reports for the commit 8b0e4fd to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2256      +/-   ##
==========================================
- Coverage   68.19%   68.17%   -0.02%     
==========================================
  Files         137      137              
  Lines       16674    16674              
==========================================
- Hits        11371    11368       -3     
- Misses       5303     5306       +3     

see 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more