mirage / mirage-crypto

Cryptographic primitives for OCaml, in OCaml (also used in MirageOS)
ISC License
77 stars 43 forks source link

github actions: actually build the code and execute the tests #154

Closed hannesm closed 2 years ago

hannesm commented 2 years ago

//cc @avsm @smorimoto to me it looks like the github actions do not compile the code and run the tests at the moment!?

hannesm commented 2 years ago

Hmm, unfortuately I don't quite understand setup-ocaml, and now when re-adding the package names to windows.yml, suddenly all these CI jobs fail with bad hash -- any clue whether this is a temporary issue, or are the windows CI systems in a desolate state? //cc @smorimoto

avsm commented 2 years ago

Not sure what's wrong here -- looks like a bug in setup-ocaml.

hannesm commented 2 years ago

I restarted the GitHub actions, and the windows compilation succeeds now.

@EduardoRFS would you be able to take a look into the cross-compilation CI and why it is failing? it complains about missing dune-configurator, but I've no clue where to adjust that... also, mirage-crypto opam file has a dependency onto dune-configuratior.

EduardoRFS commented 2 years ago

@hannesm feel free to remove it, I will not have time in the near future to maintain it, I apologize for the stress

hannesm commented 2 years ago

@EduardoRFS ok, thanks.