search

mirage / mirage-entropy

Entropy driver for MirageOS -- this has been imported into https://github.com/mirage/mirage-crypto
http://openmirage.org/
BSD 2-Clause "Simplified" License
12 stars 11 forks source link

aarch64 support #38

Closed mato closed 6 years ago

mato commented 6 years ago

We are missing aarch64 support in lib/native/entropy_cpu_stubs.c. I have opened https://github.com/ocaml/opam-repository/pull/12228 to disable installing on unsupported archs for now.

@Weichen81 AFAIK you had a patch for this?

yomimono commented 6 years ago

Just had someone run into this on IRC - would this be a huge amount of work to implement?

reynir commented 6 years ago

I was the one complaining on IRC o/

I found some assembly from a mini-os fork with aarch64 code and copied it. It compiles and runs. I don't fully understand the code, but I can make a pull request. https://github.com/reynir/mirage-entropy/commits/aarch64

hannesm commented 6 years ago

@reynir would be nice to get a PR with your changes! then we'll need someone to understand + review the change :)

Weichen81 commented 6 years ago

@mato Sorry for replying later. Yes, I have modified the mirage-entropy to run conduit_server on AArch64. But it's not easy for me to release this patch soon (Same as most companies, we need time to pass internal progress ). But I think I can comment on @reynir 's PR

hannesm commented 6 years ago

merged #39