Closed avsm closed 10 years ago
Yeah, kill it. It requires Lwt_unix
anyway, and that provides a sleep
function TIME
was used for.
In fact, when you merge it, I'll PR an even simpler way to do the same thing.
I'll cut a release after your PR and the mirage trunk patch to use this interface instead
Do not wrap
Entropy_unix
in a functor as it is meant to be used directly. This also lets it be tested directly from utop.This will also need a patch to
mirage
before 2.0.0 is cut, but I think it makes more sense to just generate a reference toEntropy_unix.connect
than to jump throughmodule Entropy = Entropy_unix.Make (OS.Time)
. Since this is a Unix user, there's no other sensible provider ofV1_LWT.TIME
.Thoughts, @samoht @djs55 @pqwy?