search

mirage / mirage-entropy

Entropy driver for MirageOS -- this has been imported into https://github.com/mirage/mirage-crypto
http://openmirage.org/
BSD 2-Clause "Simplified" License
12 stars 11 forks source link

V0.2.0 #4

Closed avsm closed 10 years ago

avsm commented 10 years ago

Do not wrap Entropy_unix in a functor as it is meant to be used directly. This also lets it be tested directly from utop.

This will also need a patch to mirage before 2.0.0 is cut, but I think it makes more sense to just generate a reference to Entropy_unix.connect than to jump through module Entropy = Entropy_unix.Make (OS.Time). Since this is a Unix user, there's no other sensible provider of V1_LWT.TIME.

Thoughts, @samoht @djs55 @pqwy?

pqwy commented 10 years ago

Yeah, kill it. It requires Lwt_unix anyway, and that provides a sleep function TIME was used for.

In fact, when you merge it, I'll PR an even simpler way to do the same thing.

avsm commented 10 years ago

I'll cut a release after your PR and the mirage trunk patch to use this interface instead