Closed djs55 closed 9 years ago
I get:
Entropy_xen: received [You may treat everything following this message as entropy.\r\n\XXX](1024 bytes) instead of expected handshake messagestate=Connected
(where XXX is random stuff I can't paste into GitHub comments)
Hm, 2 possibilities spring to mind:
connect
: the handshake will only work onceI don't really see how it's supposed to work. It calls Console_xen.read
to read the handshake and then calls it again to read the entropy, but there's no reason it shouldn't get some entropy with the first response. Here's my hacky workaround:
https://github.com/talex5/mirage-entropy/compare/djs55:use-xentropyd...handshake?expand=1
ha, yes there is that too :)
OK, the buffered reader should fix the (embarrassing) problem with the handshake message.
I've tested the following via mirage-skeleton/entropy:
xentropyd
xentropyd
isn't runningxentropyd
is runningI'm not a fan of retaining a distinction between Weak
and the other option, but I'll go ahead and merge this to get more testing. And it certainly is a big improvement over what we used to have!
Thanks!
Thanks -- hopefully we can remove the Weak
option altogether soon!
On Wed, Feb 4, 2015 at 1:49 AM, David Kaloper notifications@github.com wrote:
Merged #8 https://github.com/mirage/mirage-entropy/pull/8.
— Reply to this email directly or view it on GitHub https://github.com/mirage/mirage-entropy/pull/8#event-229740848.
Dave Scott
Support 2 kinds of entropy source:
FromHost
: we receive entropy over a console from domain 0 (or whichever other privileged domain has the entropy). This should be strong, but it requires an entropy server i.e.xentropyd
Weak
: we useRandom.self_init
and get entropy from the clock. This is weak but will work anywhere.In future we should support
RDSEED
#9 and possibly entropy from interrupt timing #10Depends on [mirage/mirage#359]
Signed-off-by: David Scott dave.scott@citrix.com