search

mirage / mirage-qubes

Mirage support for writing QubesOS AppVM unikernels
BSD 2-Clause "Simplified" License
62 stars 11 forks source link

Ipv4 signature #27

Closed hannesm closed 5 years ago

hannesm commented 5 years ago

see https://github.com/mirage/mirage-tcpip/pull/382

talex5 commented 5 years ago

I think we don't actually need to depend on mirage-dev any longer. I've made PR #28 to try removing that from Travis instead, so we won't need this PR yet.

hannesm commented 5 years ago

@talex5 oh sure, the current master of mirage-qubes does not need mirage-dev (an opam repository for staging changes that span over multiple opam packages). This PR is only needed once there is a new mirage release (+tcpip release) which changes the API of connect as proposed.

Feel free to close this PR if you dislike open PRs. I did this work to have all the users (I could find) of Static_ipv4 using the same API.

yomimono commented 5 years ago

I think this PR is superseded by later work.