search

mirage / mirage-solo5

Solo5 core platform libraries for MirageOS
ISC License
20 stars 21 forks source link

Separate API #48

Closed TheLortex closed 4 years ago

TheLortex commented 5 years ago

Depends on https://github.com/mirage/mirage-solo5/pull/47 Discussed in https://github.com/mirage/mirage-solo5/pull/45

The goal is to have a distinction between OS, the common interface between Mirage backends, and OS_Solo5 which is the solo5-specific interface. This means we have to update mirage-block-solo5 and mirage-net-solo5 accordingly.

mato commented 5 years ago

This PR appears to have both the API changes and the dune port (#f02cfcc) in it, that seems wrong.

Also, I'm missing some prose describing what the actual public API changes are, had to go and look in the dependent PRs to see (some of?) them. @TheLortex Can you add this please?

hannesm commented 4 years ago

in mirage/mirage#1010 we decided another path (see #54), so this won't be needed. closing.