search

mirage / mirage-solo5

Solo5 core platform libraries for MirageOS
ISC License
20 stars 21 forks source link

Add support for OCaml 4.10 #57

Closed kit-ty-kate closed 4 years ago

kit-ty-kate commented 4 years ago

In OCaml 4.10 the type of String_val changes from char* to const char*. Bytes_val should be used instead and it is compatible with older versions since mirage-solo5 requires at least OCaml 4.06 and Bytes_val was added in OCaml 4.06.

mato commented 4 years ago

For consistency, since we no longer support OCaml < 4.06 here, this would be a good time to also remove the backward-compatible #if defined(Bytes_val) in lib/bindings/solo5_net_stubs.c? Grepping the C stubs for other uses of String_val doesn't show anything else that needs changing.

kit-ty-kate commented 4 years ago

CI is now green. This is ready to merge.

mato commented 4 years ago

ocaml-freestanding 0.5.0 which this depends on has not yet shown up in the OPAM repository, so waiting for that.

kit-ty-kate commented 4 years ago

I'm not sure to understand, ocaml-freestanding.0.5.0 is accessible and CI succeeds because of that. What's the issue?

mato commented 4 years ago

Sorry, I didn't realise I could use the git version of ocaml/opam-repository directly.

I've rebased this on master and force-pushed to your branch, will merge once the CI goes green on the result.