search

mirage / mirage-solo5

Solo5 core platform libraries for MirageOS
ISC License
20 stars 21 forks source link

port to dune #58

Closed hannesm closed 4 years ago

hannesm commented 4 years ago

with #41 in mind, other mirage-solo5-* libraries have already been ported to dune (mirage-solo5 seems to be the only one which still uses topkg/ocamlbuild). In the light of the reviews of #47 (which is superseeded by this PR), I pushed a commit here that I had lying around for some while. It keeps the names (libmirage-solo5_bindings.a for the C stubs, built with the pkg-config'd ocaml-freestanding CFLAGS (by calling out to cflags.sh which calls pkg-config), the OCaml module is still OS), but ports the build system to dune.

the advantage from a maintenance point of view is that there's no longer any need to remember topkg and dune-release runes. existing mirage-solo5-* packages (esp. mirage-net-solo5) install fine with this PR; also an end-to-end tested unikernels (from mirage-skeleton) work well.

mato commented 4 years ago

Thanks. This was exactly the kind of change I had in mind -- ports only the build system without any public API changes. Well done.