search

mirage / mirage-solo5

Solo5 core platform libraries for MirageOS
ISC License
20 stars 21 forks source link

Remove checksum stubs according to tcpip.6.1.0 #75

Closed dinosaure closed 2 years ago

dinosaure commented 3 years ago

I'm not sure about the conflict but according to https://github.com/ocaml/opam-repository/pull/18357, we can safely delete checksum stubs.

dinosaure commented 2 years ago

I think it's fine to merge this PR, WDYT @hannesm? I just tested this PR with dns-resolver and we did not miss any symbols ad the final link step.

hannesm commented 2 years ago

indeed this looks fine to me. are there any upper bounds needed somewhere? I'm slightly confused that we don't get linker warnings about duplicate symbols.

dinosaure commented 2 years ago

indeed this looks fine to me. are there any upper bounds needed somewhere? I'm slightly confused that we don't get linker warnings about duplicate symbols.

I think ld is magic here. I already got some cases where I defined twice a function in different object files and ld never complains. Then, I'm not sure which impl. was used.