Use conf-pkg-config.2 instead of calling opam

mirage / mirage-solo5

Solo5 core platform libraries for MirageOS

ISC License

20 stars 21 forks source link

Use conf-pkg-config.2 instead of calling opam #77

Closed kit-ty-kate closed 2 years ago

kit-ty-kate commented 3 years ago

conf-pkg-config.2 brings up the correct PKG_CONFIG_PATH variable already so calling opam var is unnecessary

hannesm commented 2 years ago

Thanks for your PR. This has now a conflict. Since the cross-compilation setup (via Makefile) is shared and manually kept in sync across various repositories, I'd defer this change until we settled on how MirageOS 3 and MirageOS 4 should co-exist. If the answer is that there's no need for backwards compatibility, we will remove these cross-compilation Makefiles.

hannesm commented 2 years ago

Thanks again, since 0.7.0 release mirage-solo5 no longer uses pkg-config.