search

mirage / mirage-www

Website infrastructure and content for mirage.io
https://mirage.io
ISC License
171 stars 106 forks source link

hello world: noop requires a functor, always #807

Closed hannesm closed 1 year ago

hannesm commented 1 year ago

related to: https://github.com/mirage/mirage-skeleton/pull/359 https://github.com/mirage/mirage/pull/1428

TheLortex commented 1 year ago

Build fails due to autoreconf missing in PATH (for stdcompat library). I see you suggested a patch in omd to remove the dependency. Do you know if there are other libraries transitively depending on stdcompat ?

hannesm commented 1 year ago

I do not know, and would be happy to move over to cmarkit (as suggested in https://github.com/dune-universe/opam-overlays/issues/194), since the omd & stdcompat seems to be understaffed.

What I did as a quickfix in retreat.mirage.io is to avoid the alpha3 of omd:

--- a/config.ml
+++ b/config.ml
@@ -35,7 +35,7 @@ let management_stack =

 let packages = [
   package ~sublibs:["lwt"] "logs" ;
-  package "omd" ;
+  package ~max:"2.0.0~alpha3" "omd" ;
   package ~min:"4.5.0" "tyxml" ;
   package ~min:"3.7.1" "tcpip" ;
   package "mirage-monitoring" ;
samoht commented 1 year ago

Do you mind rebasing on master?

hannesm commented 1 year ago

this is no longer reflecting the mirage-skeleton state -- see https://github.com/mirage/mirage-skeleton/pull/367