shym commented 3 months ago

This PR fixes the small details needed to build with Mirage 4.5.1 and OCaml 5.2, in part as a way to test the PR to OCaml-Solo5 that brings support for 5.2. It comes with a CI configuration to make sure that it doesn’t build just by accident locally and also as a way to document the currently required workarounds:

using a custom overlay repository for the lwt_ppx package until the corresponding PR is merged,
pinning the ocaml-solo5 package (obviously),

but I don’t know if we want to integrate that CI run (at least as is) into the repository.

This was tested briefly locally by launching the unikernel and visiting a couple of pages. Logs didn’t seem to contain anything unexpected.

hannesm commented 6 days ago

has this been superseeded by #840?

Firobe commented 6 days ago

Essentially yes, though it would be good to keep it open for now, as a reminder that changes made to next for this should be merged back to master if we're happy with them.

shym commented 6 days ago

has this been superseeded by #840?

840 merged that change into `next`. But then I guess we’ll end up pulling the exact version that went into `next` for the next `main` rather than this PR. So I close it.

shym commented 4 days ago

Our messages were simultaneous :-) @Firobe I let you reopen this PR if you think it’s worth it.

mirage / mirage-www

Support build with Mirage 4.5.1 and OCaml 5.2 #838

840 merged that change into `next`. But then I guess we’ll end up pulling the exact version that went into `next` for the next `main` rather than this PR. So I close it.

mirage / mirage-www

Support build with Mirage 4.5.1 and OCaml 5.2 #838

840 merged that change into next. But then I guess we’ll end up pulling the exact version that went into next for the next main rather than this PR. So I close it.

840 merged that change into `next`. But then I guess we’ll end up pulling the exact version that went into `next` for the next `main` rather than this PR. So I close it.